QA·C Help - 3396

	3396	Extra parentheses recommended. A binary operation is the operand of a conditional operator.

Readability

The order in which operators are processed in this expression is not sufficiently clear and so additional parentheses are recommended. In the absence of parentheses, the sequence is determined by rules of precedence and associativity.

One operand of this conditional operator is a binary expression which is not parenthesised. Add parentheses to make it clear that the binary operator is evaluated first.

For example:


/*PRQA S 2017,3198,3199,3203,3344,3408,3401,3447 ++*/

extern int a;
extern int b;
extern int c;
extern int d;

extern void foo(void)
{
    int r;

    r = a ? b : c;                      /* OK                  */

    r = -a ? b : c;                     /* OK                  */

    r = a ? -b : c;                     /* OK                  */

    r = a > b ? c : d;                  /* Message 3396 + 3390 */
    r = (a > b) ? c : d;                /* OK                  */

    r = a + b ? c : d;                  /* Message 3396 + 3390 */
    r = (a + b) ? c : d;                /* OK                  */

    r = a ? b + c : d;                  /* Message 3396 + 3390 */
    r = a ? (b + c) : d;                /* OK                  */

    r = a ? b : c + d;                  /* Message 3396 + 3390 */
    r = a ? b : (c + d);                /* OK                  */
}

See also:

3389 Extra parentheses recommended to clarify the ordering of a % operator and another arithmetic operator (* / % + -).
3391 Extra parentheses recommended. A conditional operation is the operand of another conditional operator.
3392 Extra parentheses recommended. A shift, relational or equality operation is the operand of a second identical operator.
3393 Extra parentheses recommended. An arithmetic operation (* / + -) is the operand of a different operator with the same precedence.
3394 Extra parentheses recommended. A shift, relational or equality operation is the operand of a different operator with the same precedence.
3395 Extra parentheses recommended. A * or / operation is the operand of a + or - operator.
3397 Extra parentheses recommended. A binary operation is the operand of a binary operator with different precedence.

Personality Groups | Glossary | Message Index

Contents