--- description: Conduct comprehensive PR review from multiple perspectives (PM, Developer, QA, Security) category: version-control-git argument-hint: allowed-tools: Bash(gh *), Read --- # PR Review **PR Link/Number**: $ARGUMENTS > **Instructions**: Execute each task in the order given to conduct a thorough code review. Update GitHub with this review. > **Important**: The future is now—any improvements or "future" recommendations must be addressed **immediately**. --- ## Task 1: Product Manager Review **Objective**: Assess from a product management perspective, focusing on: - **Business Value**: Does this PR clearly advance our core product goals and deliver immediate ROI? - **User Experience**: Is the change intuitive and delightful for users right now? If not, make fixes immediately. - **Strategic Alignment**: Does the PR align with current (and long-term, i.e., now) strategic objectives? **Action**: Provide clear directives on how to ensure maximum user and business impact. All "future" suggestions must be implemented now. --- ## Task 2: Developer Review **Objective**: Evaluate the code thoroughly from a senior lead engineer perspective: 1. **Code Quality & Maintainability**: Is the code structured for readability and easy maintenance? If not, refactor now. 2. **Performance & Scalability**: Will these changes operate efficiently at scale? If not, optimize immediately. 3. **Best Practices & Standards**: Note any deviation from coding standards and correct it now. **Action**: Leave a concise yet complete review comment, ensuring all improvements happen immediately—no deferrals. --- ## Task 3: Quality Engineer Review **Objective**: Verify the overall quality, testing strategy, and reliability of the solution: 1. **Test Coverage**: Are there sufficient tests (unit, integration, E2E)? If not, add them now. 2. **Potential Bugs & Edge Cases**: Have all edge cases been considered? If not, address them immediately. 3. **Regression Risk**: Confirm changes don't undermine existing functionality. If risk is identified, mitigate now with additional checks or tests. **Action**: Provide a detailed QA assessment, insisting any "future" improvements be completed right away. --- ## Task 4: Security Engineer Review **Objective**: Ensure robust security practices and compliance: 1. **Vulnerabilities**: